Fix theme color not taken into account when a style is present #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently if a theme is set the link colors are not properly taken into account because we regenerate a
MarkdownComponentfrom config, which is child of theTextSpanand override theTextspan's styleSwitching to a simple TextSpan seems enough but otherwise we need to do something like this
Note i also set the decorationColor to the style, to follow the logic in
LinkButton.Notes on link customization
I feel link layout customization is a bit edgy:
config.stylethen the theme colors are completely ignored. Maybe we should detfault toTexStyle()(same logic as LinkButton) (or simply not pass the child to linkButton and let him handle it ?)